06-04-2008, 01:51 PM
|
#28
|
Apeopex/Millenium
|
Originally Posted by MaxOff
|
k i took a look at it.
1.) Do never and i mean never trust someone who asks for your login informations.(not even a tool).
Which is why I provide the source, compile it yourself if you don't trust me.
2.) For me the tool just chrashes the launcher
I doubt it crashes it, since it is only happening to you it's your problem not the programs.
3.) Never add yourself in "HKLMSoftwareMicrosoftWindowsCurrentVersionRun " without asking the user, a lot of secrurity tools go are very sensitive about that key.
I find it pointless to ask since security tools are going to go off when the person says yes anyway, plus this program isn't useful if you have to run it every time...
Programming Tips
4.) Close a file after u are not using it anymore. Same goes for all handels
Again, the file handle for the loginsettings.ini was never closed because I didn't want people editing it while the program was running. Also the other handle to the launcher(hProcess) never needed to be closed because it was used to kill the launcher. I.E. The handle became invalid anyway.
5.) Change the timer proc.
- The handels wont change, in the same launcher instance
No, the window handles don't change. Your point?
- Check if the launcher is ready for input or still initialising
Again, an extra piece of code that windows checks for itself. Pointless. The only time this is needed is when I wait for the Login button to become enabled.
- Check if the client was closed, because the launcher stays in the bg while fiesta is running.
No, it doesn't. I terminate it once Fiesta is running for that reason.
- Move all the code out of the Form(the best is if u dont need any form or timer)
Again, that would have been more complicated and pointless.
- Make a little bit more readable it looks kinda weird will all the exits(returns).
It's perfectly readable to me, sorry but I don't take everyone's reading preferences into account.
----
And if the tool is talkactive or not i can not say. Delphi applications are a pain in the ass to debug. So i wont take a look into it 
How are they a pain in the ass, you just need to know what your doing. The source isn't provided for you to change, it's there in case you don't trust the compiled executable.
|
All in all you seem like you read the source but mentioned stupid things without thinking about how it worked. Don't do that.
Originally Posted by Aryia
|
hmm a program to be more lazy! how neat! lol though i dont think im gonna need it cause i have 2 accounts that i switch through on fiesta, soo umm the whole typing in a username and password wont be needed after you use this program, though err thats it? kinda pointless, no? ^^ i just dont get it >.>
|
Yup, just a time saver. =P You got to be real lazy to use this XD
__________________
"Do or do not, there is no try." - Yoda
"Put off today what you can do tomorrow." - Anon
"The secret to creativity is knowing how to hide your sources." - Einstein
"Life is a long lesson in humility." - James M. Barrie
Epith
Thieving(Hawk Archer) - 51
ThievingSix(Wiz Mage) - 39
|
|
|